Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add boba sepolia superchain #683

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add boba sepolia superchain #683

wants to merge 2 commits into from
+270 −0

Conversation

boyuan-chen
Copy link

Adding a New Chain

This PR adds Boba Sepolia to the registry.

Checklist

  • I have declared the chain at the appropriate Superchain Level.
  • I have run just validate <chain-id> locally to ensure all local validation checks pass.
  • I have run just codegen to ensure that the chainlist and other generated files are up-to-date and include my chain.

@boyuan-chen boyuan-chen requested a review from a team as a code owner November 13, 2024 17:26
@Wazabie
Copy link
Contributor

Wazabie commented Nov 19, 2024

Hey @boyuan-chen , can you please make sure to follow all the steps here so we can rerun the tests and review any failing ones? Please make sure to run just codegen as well.

@boyuan-chen
Copy link
Author

Hey @boyuan-chen , can you please make sure to follow all the steps here so we can rerun the tests and review any failing ones? Please make sure to run just codegen as well.

Yes, I followed the documentation, but the just add-chain command fails at the genesis block hash comparison, so the rest of the files are not generated.

SUCCESS: add-chain
go run ./add-chain check-genesis
Loading .env
Attempting to read from /Users/***/boba-genesis/sepolia.json
failed to load genesis via op-geth: ensure chainId has already been added to registry: unknown stateless genesis definition for chain 28882
*****************
FAILED: add-chain
exit status 1
error: Recipe add-chain failed on line 10 with exit code 1

@boyuan-chen
Copy link
Author

We have patched our forked op-geth and this is the diff: ethereum-optimism/op-geth@optimism...bobanetwork:op-geth:optimism

@Wazabie
Copy link
Contributor

Wazabie commented Nov 20, 2024

@boyuan-chen we’re currently investigating this and will provide an update as soon as possible so you can rebase and proceed.

@boyuan-chen
Copy link
Author

@boyuan-chen we’re currently investigating this and will provide an update as soon as possible so you can rebase and proceed.

Sure! I have rebased the branch.

@Wazabie Wazabie self-assigned this Dec 3, 2024
@Wazabie Wazabie added F-do-not-merge Flag: Do Not Merge M-new-chain-request Meta: New Chain Request labels Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Wazabie Wazabie

Labels
F-do-not-merge Flag: Do Not Merge M-new-chain-request Meta: New Chain Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boyuan-chen @Wazabie